Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SE2 poses in Collision2D #278

Merged
merged 6 commits into from
Aug 30, 2022
Merged

Add support for SE2 poses in Collision2D #278

merged 6 commits into from
Aug 30, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Aug 25, 2022 •
edited
Loading

There is a breaking change in this PR, since SE2.xy() now returns a Point2 object instead of a tensor.

This should be merged after #277

@luisenp luisenp added the enhancement New feature or request label Aug 25, 2022
@luisenp luisenp self-assigned this Aug 25, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2022
@luisenp luisenp changed the base branch from main to lep.separate_motion_planner_objective August 25, 2022 04:22
mhmukadam
mhmukadam approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Base automatically changed from lep.separate_motion_planner_objective to main August 26, 2022 15:46
@luisenp luisenp force-pushed the lep.collision_2d_se2 branch from e5a1029 to 1d6d411 Compare August 26, 2022 15:52
@luisenp luisenp force-pushed the lep.collision_2d_se2 branch from 4f32200 to d0cba30 Compare August 30, 2022 16:57
@luisenp luisenp merged commit db154c9 into main Aug 30, 2022
@luisenp luisenp deleted the lep.collision_2d_se2 branch August 30, 2022 17:14
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Add support for SE2 poses in Collision2D (facebookresearch#278)
54d878c 
* Changed SE2.xy() to return a Point2 instead of a tensor.

* Added support for SE2 in Collision2D.

* Minor cleanup in collision jacobians test.

* SE2.translation is now an alias for SE2.xy().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

@cpaxton cpaxton Awaiting requested review from cpaxton

@fantaosha fantaosha Awaiting requested review from fantaosha

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisenp @mhmukadam @facebook-github-bot