Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update continuous integration (torch 1.13, cuda 10 dropped) #341

Closed
wants to merge 3 commits into from

Conversation

maurimo
Copy link
Contributor

@maurimo maurimo commented Nov 1, 2022

Motivation and Context

Since torch-1.13 is now used in a fundamental way (functorch), this diff upgrades the ci to use torch-1.13.
Support for Cuda 10.2 is dropped, and the reference Cuda 11 version is upgraded to 11.7 from 11.3 (as recommended by torch too).

How Has This Been Tested

Ci itself should now succeed.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2022
@maurimo maurimo changed the title Mau.update ci Update continuous integration (torch 1.13, cuda 10 dropped) Nov 1, 2022
@maurimo
Copy link
Contributor Author

maurimo commented Nov 2, 2022

@mhmukadam @luisenp @fantaosha thank you for the approval, but not merging yet maybe? as in the chat we discussed that FAIR cluster only has CUDA 11.4 so perhaps it's best to stick with the previous setup and just lock the version of functorch so it doesn't trigger update of torch to 1.13.

@maurimo
Copy link
Contributor Author

maurimo commented Nov 2, 2022

I propose to modify the CI (in another PR) so that functorch in installed together with torch, so we can make sure nothing goes wrong there and it's all in one place.

@mhmukadam
Copy link
Contributor

Okay so we can close this PR? Or should we make it a draft and revive it when we are ready to upgrade the versions.

@luisenp
Copy link
Contributor

luisenp commented Nov 2, 2022

Let's wait until I write the other PR, I think this one will be superseded by that one. Then we can close.

@luisenp luisenp marked this pull request as draft November 2, 2022 18:16
@luisenp luisenp closed this in #345 Nov 3, 2022
@mhmukadam mhmukadam deleted the mau.update_ci branch November 3, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants