Change Objective.error() so it can be vectorized w/o changing vectorized cache #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmukadam
reviewed
Nov 16, 2022
mhmukadam
reviewed
Nov 16, 2022
70a51df to
2a05cd4
Compare
mhmukadam
reviewed
Nov 16, 2022
|
Do any of the PGO example scripts need updating? Edit: based on offline discussion we do not need any updates. |
fantaosha
approved these changes
Nov 23, 2022
mhmukadam
approved these changes
Nov 23, 2022
suddhu
pushed a commit
to suddhu/theseus
that referenced
this pull request
Jan 21, 2023
…zed cache (facebookresearch#363) * Rename Objective._get_iterator() to be more descriptive. * Added an independent vectorized method for Objective.error(). * Added unit tests for new vectorization method. * Added _get_error_iter handling to Objective.vectorized and .disable_vectorization. * Fix bug in Objective.vectorized property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful for improving the accept/reject step of LM, and for more complex line search later.
Closes #231.
Note that as a consequence of this, this PR changes PGO optimization numerical results because now Objective.error() returns the non-scaled weighted error for
RobustCostFunction, while the previous version was returning the scaled one.