Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theseus.geometry.functional.so3.inverse() #374

Merged
merged 5 commits into from
Nov 26, 2022
Merged

Add theseus.geometry.functional.so3.inverse() #374

merged 5 commits into from
Nov 26, 2022

Conversation

fantaosha
Copy link
Contributor

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fantaosha fantaosha added the enhancement New feature or request label Nov 23, 2022
@fantaosha fantaosha self-assigned this Nov 23, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2022
luisenp
luisenp approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@luisenp luisenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@luisenp
Copy link
Contributor

luisenp commented Nov 23, 2022

Can we also close #366?

@fantaosha fantaosha changed the title Taoshaf.functional.so3.inverse Add theseus.geometry.functional.so3.inverse() Nov 23, 2022
@fantaosha
Copy link
Contributor Author

Can we also close #366?

Closed.

Base automatically changed from taoshaf.funtional.so3.adjoint to main November 26, 2022 02:53
@fantaosha fantaosha force-pushed the taoshaf.functional.so3.inverse branch from 8f01664 to 8d621d3 Compare November 26, 2022 03:07
@fantaosha fantaosha merged commit 40dd795 into main Nov 26, 2022
@fantaosha fantaosha deleted the taoshaf.functional.so3.inverse branch November 26, 2022 03:32
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@fantaosha
Add theseus.geometry.functional.so3.inverse() (facebookresearch#374)
f843071 
* add SO3.inverse()

* add tests for SO3.inverse

* fixed the output bug for jinverse

* add a comment about op_autograd_fn

* add comments that _jxxx_impl might not exist for some operators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

@luisenp luisenp luisenp approved these changes

Assignees

@fantaosha fantaosha

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fantaosha @luisenp @mhmukadam @facebook-github-bot