Add a workaround for NonlinearOptimizer rejecting all batch steps #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantaosha
reviewed
Nov 30, 2022
f8c4d48 to
a8d3dc7
Compare
fantaosha
approved these changes
Dec 1, 2022
mhmukadam
reviewed
Jan 2, 2023
| @@ -107,6 +107,8 @@ def resolve(key: Union[str, "BackwardMode"]) -> "BackwardMode": | |||
| # ignoring indices given by `reject_indices` | |||
| # 3. Check convergence | |||
| class NonlinearOptimizer(Optimizer, abc.ABC): | |||
| _MAX_ALL_REJECT_ATTEMPTS = 3 | |||
There was a problem hiding this comment.
Any tradeoff or overhead to consider here? Curious about the choice of 3 attempts. Are these all kept in the compute graph?
Also might be helpful to add in a comment that these max attempts are per iteration and not overall.
suddhu
pushed a commit
to suddhu/theseus
that referenced
this pull request
Jan 21, 2023
…cebookresearch#388) * Small refactor of nonlinear optimizer _step. * Included use of adaptive damping in end-to-end test. * Changed all reject logic to skip the latest iteration. * Added NonlinearOptimizer._error_metric() method. * Prevented incorrect combination of ellipsoidal and adaptive damping in LM. * Fix LM unit test to account for unsupported damping case (ellipsoidal + adaptive).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version we sometimes have to recompute the error norm if some steps are rejected, so optimizing error vectorization becomes important again. Will fix in a separate PR.