Use IMPLICIT for test_theseus_layer and fix related bugs #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmukadam
reviewed
Jan 17, 2023
| **kwargs, | ||
| ) -> Tuple[torch.Tensor, bool]: | ||
| tensor_dict, err = self._compute_retracted_tensors_and_error( | ||
| delta, converged_indices, force_update | ||
| ) | ||
| reject_indices = self._complete_step(delta, err, previous_err, **kwargs) | ||
| if truncated_grad_loop: |
There was a problem hiding this comment.
Can't remember, is the implicit grad part of the truncated_grad_loop flag?
There was a problem hiding this comment.
Yes, truncated_grad_loop is the final attached loop of "TRUNCATED" and "IMPLICIT". I was thinking that this is kind of a confusing name tbh.
There was a problem hiding this comment.
Yeah we could rename to implicit_and_trunc_grad_block or maybe ..._loop is okay. We can also add a comment to clarify.
mhmukadam
approved these changes
Jan 17, 2023
bamos
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.