Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New NonlinearOptimizer hierarchy #440

Merged
merged 4 commits into from
Feb 6, 2023
Merged

New NonlinearOptimizer hierarchy #440

merged 4 commits into from
Feb 6, 2023

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jan 19, 2023

This PR moves the logic specific to nonlinear least squares problems from NonlinearOptimizer to the NonlinearLeastSquares subclass. The base class now only provides some default info tracking methods, and defines an abstract method called _error_metric(), which can be used instead of the previously hardcoded sum of squares.

@luisenp luisenp self-assigned this Jan 19, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2023
@luisenp luisenp marked this pull request as ready for review January 19, 2023 19:17
@luisenp luisenp force-pushed the lep.new_nlopt_hierarchy branch from 58abb7a to ff1dcb1 Compare January 19, 2023 19:19
mhmukadam
mhmukadam approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

joeaortiz
joeaortiz approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@joeaortiz joeaortiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dishank-b
dishank-b reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@dishank-b dishank-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

theseus/optimizer/nonlinear/nonlinear_least_squares.py Show resolved Hide resolved
theseus/optimizer/nonlinear/nonlinear_least_squares.py Show resolved Hide resolved
This was referenced Feb 1, 2023
Open
Merged
@luisenp luisenp force-pushed the lep.new_nlopt_hierarchy branch from 6b8e5ea to cf9ae43 Compare February 2, 2023 12:32
@luisenp
Moved error metric to Objective (#455)
f0c8546 
* Deprecated Objective.error_squared_norm() for configurable error_metric().

* Made error metric configurable, and remove _error_metric method from NL optimizer class.
@luisenp luisenp merged commit 16c8740 into main Feb 6, 2023
@luisenp luisenp deleted the lep.new_nlopt_hierarchy branch February 6, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dishank-b dishank-b dishank-b approved these changes

@joeaortiz joeaortiz joeaortiz approved these changes

@fantaosha fantaosha fantaosha approved these changes

@mhmukadam mhmukadam mhmukadam approved these changes

@bamos bamos bamos approved these changes

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@luisenp @bamos @mhmukadam @fantaosha @dishank-b @joeaortiz @facebook-github-bot