Change in data model in test_theseus_layer

[dishank-b]

Motivation and Context

The data model was wrong as in it had to two optima, leading to some of the optimizer not able to pass the test. The comments in the file also suggests that the intentional model and actually implemented model were different.

How Has This Been Tested

All the current optimizer passes the test with the changed model.

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have completed my CLA (see CONTRIBUTING)
• I have added tests to cover my changes.
• All new and existing tests passed.

[dishank-b]

@mhmukadam @luisenp, made changes in the test_theseus_layer. They were causing bug for DCEM convergence.

Also, in the comments in the file, it say the model we want to have is f(x) = Ax^2+b whereas the one implemented was f(x) = (Ax)^2+b. I corrected it now. Though verify the change in the grad once. I feel the grad in previous version also wrong for the model we had.

[mhmukadam]

LGTM, thanks for the fix. Just one comment.

[luisenp]

Thanks for the fix!

[dishank-b]

Thanks. Can we merge this then? Then I will rebase the DCEM PR on top of this.