Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Labs API #488

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Update Labs API #488

merged 2 commits into from
Mar 22, 2023

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Mar 22, 2023

No description provided.

luisenp added 2 commits March 22, 2023 14:26
@luisenp
Improvements to Lie Labs API.
c1fbd5a 
* Added '*' operator and removed all others, along with TangentTensor class.

* Moved rand and randn to members of SE3 and SO3.

* Moved static methods like exp and hat to SE3 and SO3.
@luisenp
Add @ operator aliasing transform_from.
1008b4f
@luisenp luisenp requested a review from fantaosha March 22, 2023 21:28
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2023
@luisenp luisenp requested a review from mhmukadam March 22, 2023 21:32
@luisenp luisenp merged commit e0c271e into main Mar 22, 2023
@luisenp luisenp deleted the lep.update_labs_api branch March 22, 2023 21:55
mhmukadam
mhmukadam reviewed Mar 23, 2023
View reviewed changes
Copy link
Contributor

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam left review comments

@fantaosha fantaosha Awaiting requested review from fantaosha

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisenp @mhmukadam @facebook-github-bot