Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SE3.normalize() #506

Merged
merged 12 commits into from
May 2, 2023
Merged

Implement SE3.normalize() #506

merged 12 commits into from
May 2, 2023

Conversation

fantaosha
Copy link
Contributor

@fantaosha fantaosha commented May 1, 2023 •
edited
Loading

Motivation and Context

Implement differentiable SO3.normalize() and SE3.normalize()

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2023
@fantaosha fantaosha requested review from luisenp and mhmukadam May 1, 2023 22:28
@fantaosha fantaosha self-assigned this May 1, 2023
@fantaosha fantaosha added the enhancement New feature or request label May 1, 2023
@fantaosha fantaosha changed the title Implement SO3.normalize() Implement SE3.normalize() May 1, 2023
@fantaosha fantaosha merged commit 48753cb into main May 2, 2023
@fantaosha fantaosha deleted the taoshaf.normalize_SO3 branch May 2, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisenp luisenp Awaiting requested review from luisenp

@mhmukadam mhmukadam Awaiting requested review from mhmukadam

Assignees

@fantaosha fantaosha

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fantaosha @facebook-github-bot @luisenp