Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-batch support for SE(3) unary operators #512

Merged
merged 14 commits into from
May 4, 2023
Merged

Add multi-batch support for SE(3) unary operators #512

merged 14 commits into from
May 4, 2023

Conversation

fantaosha
Copy link
Contributor

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 3, 2023
@fantaosha fantaosha requested review from luisenp and mhmukadam May 4, 2023 01:56
@fantaosha fantaosha self-assigned this May 4, 2023
@fantaosha fantaosha added the enhancement New feature or request label May 4, 2023
luisenp
luisenp approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@luisenp luisenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only left some minor comments. And very nice clean up on the exp/log map code :)

theseus/labs/lie/functional/se3_impl.py Outdated Show resolved Hide resolved
theseus/labs/lie/functional/se3_impl.py Outdated Show resolved Hide resolved
theseus/labs/lie/functional/se3_impl.py Show resolved Hide resolved
theseus/labs/lie/functional/se3_impl.py Show resolved Hide resolved
theseus/labs/lie/functional/se3_impl.py Show resolved Hide resolved
@fantaosha fantaosha merged commit 1c490f6 into main May 4, 2023
@fantaosha fantaosha deleted the taoshaf.multi_batch_se3_unary_ops branch May 4, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisenp luisenp luisenp approved these changes

@mhmukadam mhmukadam Awaiting requested review from mhmukadam

Assignees

@fantaosha fantaosha

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fantaosha @luisenp @facebook-github-bot