Multi-batch unit tests for Lie groups #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned to single-batch-dim output.
fantaosha
approved these changes
Jun 16, 2023
| all_input_types, atol = get_test_cfg(op_name, dtype, dim, data_shape, module=module) | ||
| for input_types in all_input_types: | ||
| inputs = sample_inputs(input_types, batch_size, dtype, rng) | ||
| funcs = ( | ||
| tuple(left_project_func(module, x) for x in inputs) | ||
| tuple(left_project_func(module, x, bs) for x in inputs) |
There was a problem hiding this comment.
Wondering if we need to check bs=None or dim_out=None, which assumes no broadcasting and is most common user-case.
There was a problem hiding this comment.
I thought the case tuple() covered this for the no batch size (see line 10). Or do you mean something else?
The tests for different dim_out are in #527.
| matrix = matrix[sels, ..., sels, :, :] | ||
| g = group.reshape(d, *group.shape[-2:]) | ||
| # Compute projected gradient matrix | ||
| ret = module._left_project_autograd_fn(g, matrix) |
There was a problem hiding this comment.
Do we assume the same dimension of inputs and outputs?
There was a problem hiding this comment.
Yes, I think so. There should be no broadcasting in the test where this function is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing unit test for gradient ops