Fix installing from source on Windows by explicitly mentioning cusparse in setup.py #534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, when building from source on windows with CUDA 11.8 and Visual Studio 2022, one gets the following error - noticeably, this build command mentions
cusolver.lib c10.lib torch.lib torch_cpu.lib
etc, but not cusparse.lib. I haven't ran every test but this works with the basic ones that don't require installing a lot of dependencies, like theseus layer.How Has This Been Tested
I only have the capability to test this change on my current windows machine - building works fine on a linux VM I tried.
Types of changes
Checklist