Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SO3 rotate check #541

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix SO3 rotate check #541

merged 1 commit into from
Jun 22, 2023

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jun 21, 2023

Closes #535

@luisenp luisenp requested a review from fantaosha June 21, 2023 21:11
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 21, 2023
fantaosha
fantaosha approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@fantaosha fantaosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@luisenp luisenp merged commit 8a9f5b1 into main Jun 22, 2023
@luisenp luisenp deleted the lep.rotate_check_fix branch June 22, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantaosha fantaosha fantaosha approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Theseus SO3 rotate check
3 participants
@luisenp @fantaosha @facebook-github-bot