Add untransform #552
Merged
Add untransform #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmukadam
reviewed
Jun 27, 2023
| return [jacobian_g, jacobian_p], ret | ||
|
|
||
|
|
||
| class UntransformFrom(lie_group.BinaryOperator): |
There was a problem hiding this comment.
UntransformFrom -> Untransform ?
mhmukadam
reviewed
Jun 27, 2023
| return [jacobian_g, jacobian_p], ret | ||
|
|
||
|
|
||
| class UntransformFrom(lie_group.BinaryOperator): |
There was a problem hiding this comment.
UntransformFrom -> Untransform ?
mhmukadam
approved these changes
Jun 27, 2023
luisenp
approved these changes
Jun 27, 2023
| @@ -261,34 +261,8 @@ def transform_to( | |||
| jacobians: Optional[List[torch.Tensor]] = None, | |||
| ) -> Point3: | |||
There was a problem hiding this comment.
@mhmukadam Do we want to make a similar (future) change on theseus? If so, I can make this in another PR so that we add a deprecation message and an alias for the new names.
There was a problem hiding this comment.
Yes in general it would ideal to make the naming consistent with torchlie so it isn't confusing. Sounds good on adding the deprecation warning.
c87c4be to
c52deba
Compare
2b31997 to
567e51b
Compare
08083a3 to
85b0cb7
Compare
567e51b to
61f5382
Compare
85b0cb7 to
2cd5aee
Compare
61f5382 to
46a5b66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested
Types of changes
Checklist