Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the rotation and translation order in pgo datasets #560

Merged
merged 3 commits into from
Jul 6, 2023
Merged

fixed the rotation and translation order in pgo datasets #560

merged 3 commits into from
Jul 6, 2023

Conversation

fantaosha
Copy link
Contributor

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2023
@fantaosha fantaosha self-assigned this Jun 27, 2023
@fantaosha fantaosha added the bug Something isn't working label Jun 27, 2023
mhmukadam
mhmukadam reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

@mhmukadam mhmukadam mentioned this pull request Jun 27, 2023
Closed
11 tasks
suddhu
suddhu approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@suddhu suddhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhmukadam mhmukadam merged commit 5bf71c0 into main Jul 6, 2023
@mhmukadam mhmukadam deleted the taoshaf.fix_pgo_noise branch July 6, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suddhu suddhu suddhu approved these changes

@mhmukadam mhmukadam mhmukadam approved these changes

@luisenp luisenp Awaiting requested review from luisenp

Assignees

@fantaosha fantaosha

@suddhu suddhu

Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fantaosha @mhmukadam @suddhu @facebook-github-bot