Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken sksparse install in CI #582

Merged
merged 15 commits into from
Jul 20, 2023
Merged

Fix broken sksparse install in CI #582

merged 15 commits into from
Jul 20, 2023

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jul 18, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2023
@luisenp luisenp force-pushed the lep.skparse_install_fix_ci branch from 9f2b2ca to 38af5cf Compare July 18, 2023 16:50
@luisenp luisenp force-pushed the lep.skparse_install_fix_ci branch from 6f4d712 to e17ea5f Compare July 18, 2023 17:24
@luisenp luisenp force-pushed the lep.skparse_install_fix_ci branch from 9eb622d to 219b292 Compare July 18, 2023 18:29
@luisenp luisenp changed the title Testing conda install for py38 in CI Fix broken sksparse install in CI Jul 19, 2023
@luisenp luisenp force-pushed the lep.skparse_install_fix_ci branch from 8130d2f to 05cf6dd Compare July 20, 2023 04:34
@luisenp luisenp requested review from mhmukadam and maurimo July 20, 2023 04:42
fantaosha
fantaosha approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@fantaosha fantaosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luisenp luisenp merged commit 148e383 into main Jul 20, 2023
@luisenp luisenp deleted the lep.skparse_install_fix_ci branch July 20, 2023 15:06
YipuZhao pushed a commit that referenced this pull request Jul 20, 2023
@luisenp @YipuZhao
Fix broken sksparse install in CI (#582)
1d6ea7b 
* Testing conda install for py38 in CI.

* Add export conda path to activate_theseus.

* Added missing conda create command to py38 config.

* Add source activate theseus everywhere. Test on py38.

* Adding the same changes to some of the other tests.

* Added sksparse install to other failing tests.

* Added install_theseus command to CI config.

* Fix some CI errors.

* Cleaned up CI config.

* Added explicit del in baspacho solver test to try to fix flaky tests.

* Made a simpler CPU baspacho test for CI.

* Changed scikit-sparse requirements to install from Github.

* Testing with 0.4.9 install, that should resolved Cython issue.

* Install sksparse directly from Github zip.
mhmukadam
mhmukadam reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I guess we'll switch to the 0.4.11 scikit-sparse available on pypi now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam left review comments

@fantaosha fantaosha fantaosha approved these changes

@maurimo maurimo Awaiting requested review from maurimo

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luisenp @mhmukadam @fantaosha @facebook-github-bot