Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to show/hide timestamps on the 3x2 widget #373

Merged

Conversation

marceldallagnol
Copy link

First of all, great job. The app's pretty great!
I felt like the timestamps displayed on every note in the widget cluttered it a bit, so I changed a few things and added an option under settings/interface that allows the user to toggle the display of these timestamps.
I have never done any real Android development, and apologize in advance for any roughness in the code. If anything should be changed to meet style guidelines, of if something should be placed somewhere else, please let me know. I hope this adds a little bit of interesting functionality (it did to me, at least).
Also, since I tried to keep my changes to a minimum, I didn't shrink the footer on the notes, so there's some extra space in there (to be honest, I'd need a fair bit more fiddling around to remove it). I want to try changing the display of different lines of a same note in the widget, too. Currently, subsequent lines are separated by spaces (not by newlines), while expectation would be that they would have line breaks in between. If it would be interesting to be able to personalize the widget (most of the time I'm only checking notes, so that the widget is the most important feature to me), maybe a section "Widget" under "Interface" could be added - I felt adding an extra button, especially prefixed by "setting_", was a little off, but it's where I thought it fit best.

Hope this helps somewhat. Cheers!
Marcel

@federicoiosue
Copy link
Owner

Hi! That sounds great and is a nice idea but all settings about widgets should be managed into the "add new widget" option dialog. The one where you choose if to include or not thumbnails and eventually the category to filter notes.

I think that would a perfect place to move your modification into, what do you think?

@marceldallagnol
Copy link
Author

Much better! How does this look?

Repository owner deleted a comment Jun 17, 2017
Repository owner deleted a comment Jun 17, 2017
@federicoiosue federicoiosue force-pushed the develop branch 5 times, most recently from 10e8b30 to 6168785 Compare June 27, 2017 09:56
@federicoiosue federicoiosue merged commit aa8fbda into federicoiosue:develop Nov 13, 2017
@federicoiosue
Copy link
Owner

federicoiosue commented Nov 13, 2017

Great job!
Sorry for the really late merge but developments stopped for a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants