-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: backup and restore settings #1427
feat: backup and restore settings #1427
Conversation
57958d8
to
57d6feb
Compare
Signed-off-by: Pedro Lamas <[email protected]>
57d6feb
to
678a3b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM functionality wise, but what do you think of adding an additional key to the export (e.g. "fluidd": "v1.2.3"
) and using it to check if the selected backup file actually is a fluidd config export before restoring it?
I like the idea of adding the version to it, that makes complete sense to me! Confirming if it is a Fluidd backup or not is tricky, as this is just a JSON file... granted we could have some schema to check against but that makes versioning very tricky! |
Well, using a |
Signed-off-by: Pedro Lamas <[email protected]>
Agreed! 🙂 |
Signed-off-by: Pedro Lamas <[email protected]>
Following the comments, I made output filename is now "backup_fluidd__.json" The JSON blob is now using this format: {
"meta": {
"app": "Fluidd",
"version": "1.2.3",
"type": "settings-backup"
},
"data": {}
} We will verify that Should be enough to validate the expected format and that version will allow us flexibility in the future if we want to! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Good Job!, great job! |
Add a new Backup and Restore buttons to easily export and import Fluidd settings across multiple printers.
As a first implementation, this will backup/restore ALL Fluidd settings (there is no selections of specific parts of the settings).
Resolve #1113