Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to Support for Nginx Ingress Canary #169

Closed
bzon opened this issue May 6, 2019 · 3 comments · Fixed by #170
Closed

Feature to Support for Nginx Ingress Canary #169

bzon opened this issue May 6, 2019 · 3 comments · Fixed by #170
Labels
kind/feature Feature request

Comments

@bzon
Copy link

bzon commented May 6, 2019

It would be good if Flagger can support Workloads that depends on Nginx Ingress Controller's Canary annotations.

Basing on the architecture diagram of Flagger, the VirtualService “adjust weight” seems like possible to be also implemented to an Ingress Object that uses Nginx Ingress Controller Class.

@stefanprodan
Copy link
Member

stefanprodan commented May 6, 2019

Flagger generates and owns the VirtualService and the ClusterIP services, but for an Ingress object I don't see how would this work without pulling into the Canary CRD the whole Ingress spec.

@stefanprodan
Copy link
Member

One option would be to introduce an ingressRef in the Canary CRD that would work similar to the HPA ref. Flagger would use an existing ingress to create the canary clone and adjust the weight for progressive delivery or the header/cookie for A/B testing.

@stefanprodan
Copy link
Member

Nginx doesn't report metrics for canaries kubernetes/ingress-nginx#4026 so Flagger can't have built-in checks for HTTP errors or latency. The apps must be instrumented and custom metrics checks must be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants