Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If generated VirtualService already exists update it #51

Merged
merged 2 commits into from
Feb 20, 2019

Conversation

carlossg
Copy link
Contributor

Only if spec has changed

@carlossg
Copy link
Contributor Author

this doesn't quite work, it is updating the vritualservice every minute

@codecov-io
Copy link

Codecov Report

Merging #51 into master will decrease coverage by 0.29%.
The diff coverage is 78.12%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #51     +/-   ##
=========================================
- Coverage   56.63%   56.34%   -0.3%     
=========================================
  Files           9        9             
  Lines        1333     1340      +7     
=========================================
  Hits          755      755             
- Misses        446      452      +6     
- Partials      132      133      +1
Impacted Files Coverage Δ
pkg/controller/router.go 83.16% <78.12%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2a22a...0c0ebae. Read the comment docs.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlossg

@stefanprodan stefanprodan merged commit 7c6b88d into fluxcd:master Feb 20, 2019
@carlossg carlossg deleted the update-virtualservice branch February 20, 2019 09:39
@carlossg
Copy link
Contributor Author

is there an easy way to compare the full spec?

@stefanprodan
Copy link
Member

@stefanprodan
Copy link
Member

stefanprodan commented Feb 20, 2019

I'll refactor the Virtual Service update before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants