Add user-specified labels/annotations to Canary for generated Services #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@splkfinn looks good so, can you please check my comments and add unit tests.
Thanks
3c23966
to
dad6dff
Compare
stefanprodan
requested changes
Apr 1, 2020
76deff2
to
d34d60f
Compare
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
+ Coverage 52.44% 52.65% +0.20%
==========================================
Files 63 63
Lines 4919 4938 +19
==========================================
+ Hits 2580 2600 +20
+ Misses 1931 1930 -1
Partials 408 408
Continue to review full report at Codecov.
|
stefanprodan
approved these changes
Apr 4, 2020
There was a problem hiding this comment.
LGTM
The test coverage is not that great but I'm ok with merging this and do a followup PR.
Thanks @splkfinn
and metadata parameter is nil on finalize. in response to PR feedback
d34d60f
to
84dd000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working to resolve #510, this is the change set I have (so far).