Don't attach events directly to document

Fixes #20
fregante · Oct 10, 2020 · 8795011 · 8795011
1 parent 66e5cc2
commit 8795011
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/index.ts b/index.ts
@@ -78,7 +78,8 @@ function delegate<TElement extends Element = Element, TEvent extends Event = Eve
 		};
 	}
 
-	const baseElement = base; // Required for TypeScript
+	// `document` should never be the base, it's just an easy way to define "global event listeners"
+	const baseElement = base instanceof Document ? base.documentElement : base;
 
 	// Handle the regular Element usage
 	const capture = Boolean(typeof options === 'object' ? options.capture : options);

diff --git a/package.json b/package.json
@@ -29,6 +29,7 @@
       "browser"
     ],
     "rules": {
+      "max-params": 0,
       "prefer-rest-params": 0,
       "import/extensions": 0,
       "unicorn/import-index": 0,

diff --git a/test.js b/test.js
@@ -18,6 +18,7 @@ const {window} = new JSDOM(`
 
 global.Event = window.Event;
 global.Element = window.Element;
+global.Document = window.Document;
 global.document = window.document;
 const container = window.document.querySelector('ul');
 const anchor = window.document.querySelector('a');