Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve single-element detection (#4)" #12

Merged
merged 1 commit into from
May 20, 2019

Conversation

stof
Copy link
Contributor

@stof stof commented May 20, 2019

This reverts commit 09766e3.

Any other modern feature used in this fork can either be transpiled by Babel or polyfilled for IE 11. But nodes being an instance of the EventTarget constructor cannot be polyfilled. And IE 11 does not expose
EventTarget as a constructor.
Reverting the detection to the method of the EventTarget interface avoids relying on a non-polyfillable API.

This is based on the discussion happening in #8.

This reverts commit 09766e3.

Any other modern feature used in this fork can either be transpiled by
Babel or polyfilled for IE 11. But nodes being an instance of the
EventTarget constructor cannot be polyfilled. And IE 11 does not expose
EventTarget as a constructor.
Reverting the detection to the method of the EventTarget interface
avoids relying on a non-polyfillable API.
@fregante fregante merged commit 746fd61 into fregante:master May 20, 2019
@stof stof deleted the partial_ie_support branch May 20, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants