Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for events triggered on text nodes #21

Merged
merged 5 commits into from
Nov 9, 2020
Merged

Conversation

fregante
Copy link
Owner

@fregante fregante commented Nov 9, 2020

This is currently failing because selectstart is dipatched on the text node, which doesn't have the .closest method.

delegate(document, 'p', 'selectstart', console.log);

TypeScript had tried to warn me but I had half-assed my way out of it 😅

@fregante fregante added the bug Something isn't working label Nov 9, 2020
@fregante fregante merged commit 60bfecb into master Nov 9, 2020
@fregante fregante deleted the text-nodes branch November 9, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant