Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed MAC/FLOP computation for Linear in higher dimensions #52

Merged
merged 9 commits into from
May 17, 2022

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented May 17, 2022

Following up on #50, this PR introduces the following modifications:

  • fixed MAC & flop computation for nn.Linear in high dimensions
  • updated unittests
  • fixed arg description for summary

Closes #50

@frgfm frgfm added this to the 0.1.2 milestone May 17, 2022
@frgfm frgfm self-assigned this May 17, 2022
@frgfm frgfm added bug Something isn't working topic: docs Improvements or additions to documentation module: crawler Related to crawler module: modules Related to modules ext: test labels May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #52 (e4d2829) into master (61116d9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   90.35%   90.37%   +0.01%     
==========================================
  Files          10       10              
  Lines         674      675       +1     
==========================================
+ Hits          609      610       +1     
  Misses         65       65              
Impacted Files Coverage Δ
torchscan/crawler.py 82.08% <ø> (ø)
torchscan/modules/flops.py 97.59% <100.00%> (+0.01%) ⬆️
torchscan/modules/macs.py 100.00% <100.00%> (ø)

@frgfm frgfm merged commit 358edb6 into master May 17, 2022
@frgfm frgfm deleted the linear-fix branch May 17, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module: crawler Related to crawler module: modules Related to modules topic: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linear layer macs?
1 participant