Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Renamed variables to avoid built-in names #73

Merged
merged 2 commits into from
Aug 3, 2022
Merged

style: Renamed variables to avoid built-in names #73

merged 2 commits into from
Aug 3, 2022

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Aug 3, 2022

This PR renames several variables that were flagged as built-in names.

@frgfm frgfm added type: improvement New feature or request module: crawler Related to crawler module: modules Related to modules topic: style labels Aug 3, 2022
@frgfm frgfm added this to the 0.1.2 milestone Aug 3, 2022
@frgfm frgfm self-assigned this Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #73 (81bc1bf) into main (d8f0d68) will not change coverage.
The diff coverage is 99.13%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   92.95%   92.95%           
=======================================
  Files          10       10           
  Lines         667      667           
=======================================
  Hits          620      620           
  Misses         47       47           
Impacted Files Coverage Δ
torchscan/modules/receptive.py 83.78% <87.50%> (ø)
torchscan/crawler.py 84.32% <100.00%> (ø)
torchscan/modules/flops.py 97.51% <100.00%> (ø)
torchscan/modules/macs.py 100.00% <100.00%> (ø)
torchscan/modules/memory.py 100.00% <100.00%> (ø)

@frgfm frgfm merged commit 4e327c2 into main Aug 3, 2022
@frgfm frgfm deleted the codacy-fix branch August 3, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: crawler Related to crawler module: modules Related to modules topic: style type: improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant