-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependencies for building docs #1613
Conversation
This essentially replicates the environment in https://github.com/fsspec/filesystem_spec/blob/master/docs/environment.yml . It seems like a bad idea to have the environment in two places. |
I have addressed this in the latest commit. |
Apparently the JSON serialization changed format slightly |
Seems that this was introduced by #1562. Imo we should fix that in a separate PR. |
The tests passed at the time, so some version got updated. Since it's a one-character fix, I'd be happy to see it here. |
The problem is not that trivial. Seems that the separator in |
It's find to importorskip("ujson") for the test, and we know that the package will be there in CI. |
I found a better solution, which is to use the same json module to encode the dictionary for the reference value inside the test. |
I found that I couldn't build the documentation just from installing
dev
andtest
dependencies. It turns out thatpyproject.toml
currently does not specify the dependencies for building the documentation.This PR adds the
doc
extra which includes such dependencies, making it easier to set up the environment for building documentation.