Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality Descriptions #208

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Code Quality Descriptions #208

merged 2 commits into from
Mar 27, 2019

Conversation

mlapaglia
Copy link

@mlapaglia mlapaglia commented Jan 19, 2019 •
edited
Loading

The official documentation says to use description instead of check_name.
An example error:
image

See the results this has:
check_name:
image

description:
image

@mlapaglia mlapaglia mentioned this pull request Jan 19, 2019
Open
@mlapaglia mlapaglia changed the title Code Quality Desrcriptions Code Quality Descriptions Jan 19, 2019
@lukaspj lukaspj mentioned this pull request Feb 5, 2019
Merged
@lukaspj
Copy link

lukaspj commented Feb 5, 2019

Hey @mlapaglia you forgot to update the ReporterBuilderTest.java file at line 554.
A find and replace of check_name to description should make the test pass.

Similarly for ReporterTest, line 134 and 156

@mlapaglia
Copy link
Author

Thanks @lukaspj , updated

@Sidnioulz Sidnioulz mentioned this pull request Feb 13, 2019
Closed
This was referenced Mar 10, 2019
Closed
Open
@gabrie-allaigre gabrie-allaigre merged commit 3ac1404 into gabrie-allaigre:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlapaglia @lukaspj @gabrie-allaigre