add declaration file (index.d.ts) #151
Conversation
|
Thank you for this PR! This will sure come in handy for our users! I'll have to review it and then add it in Galio's next version. This will probably happen after New Year Eve. You've done a great help to our community ❤️! |
|
@palingheorghe I don't know icon font type is correct or not? But some fonts are not working Some of the prop types in your document are incorrect so I can hardly write them correctlytype IconFamilyType =
| 'Galio'
| 'AntDesign'
| 'Entypo'
| 'EvilIcons'
| 'Feather'
| 'FontAwesome'
| 'FontAwesome5'
| 'Fontisto'
| 'Foundation'
| 'Ionicons'
| 'MaterialIcons'
| 'MaterialCommunityIcons'
| 'Octicons'
| 'Zocial'
| 'SimpleLineIcons'; |
|
Hi @wiloke1 ! You can find more about the font family type names here: https://github.com/galio-org/galio/blob/master/src/helpers/getIconType.js . These must be: |
|
👍 adding myself to that, is this going to be released anytime soon? |
|
We are working on releasing hotfixes for immediate pending issues, will discuss on considering adding this pull request to that list with the others after review... Am confident it will be added pretty soon... |
|
just wanted to add my support for this PR - I could really do with it right now 👍 |
| shadow?: boolean; | ||
| borderless?: boolean; | ||
| image?: string; | ||
| imageBlockStyle?: strubg; |
| rounded?: boolean; | ||
| borderless?: boolean; | ||
| viewPass?: boolean; | ||
| icon?: string; |
There was a problem hiding this comment.
Can you add the iconContent prop?
https://github.com/galio-org/galio/blob/master/src/Input.js#L152
|
merge please .. please? lol |
Adding declaration file helps editor suggest props for you and report errors typescript