Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit who can approve or request changes to pull requests in open source projects #212

Closed
github-product-roadmap opened this issue Jul 12, 2021 · 1 comment
Labels
all Product SKU: All cloud Available on Cloud ga Feature phase: Generally available shipped Shipped

Comments

@github-product-roadmap
Copy link
Collaborator

Summary

Currently, any user can approve or request changes to a pull request in an open source project even if they have no relationship to the project. This can be confusing both for that user and for the pull request author, who may think their changes were approved (or rejected). This can also be a source of frustration for open source maintainers.

A new moderation setting will let open source projects limit who can approve and request changes. Users can still review changes and submit comments, but will not be able to approve or request changes when enabled:

Intended Outcome

Helps reduce the confusion caused when a user with no relationship to an open source project approves or requests changes to a pull request in that project.

How will it work?

A new moderation setting will let open source project admins restrict "approve" and "request changes" reviews to certain types of users, similar to the options available for interaction limits. For example:

image

When enabled, users can still review pull requests and submit comments, but will not be able to approve or request changes if they do not have the required relationship to the project.

@github github locked and limited conversation to collaborators Jul 12, 2021
@github-product-roadmap github-product-roadmap added cloud Available on Cloud in design Feature phase: in design labels Jul 12, 2021
@Sid-ah Sid-ah moved this to Future in GitHub Public Roadmap Oct 8, 2021
@github-product-roadmap github-product-roadmap added code ga Feature phase: Generally available and removed in design Feature phase: in design labels Oct 13, 2021
@Sid-ah Sid-ah moved this from Future to Q4 2021 – Oct-Dec in GitHub Public Roadmap Oct 18, 2021
@Sid-ah Sid-ah closed this as completed Nov 16, 2021
@Sid-ah Sid-ah added the shipped Shipped label Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
all Product SKU: All cloud Available on Cloud ga Feature phase: Generally available shipped Shipped
Projects
Archived in project
Development

No branches or pull requests

2 participants