short-circuit and return no matching route for empty param values

[pkieltyka]

No description provided.

[pkieltyka]

hey @dvic - thanks for the PR on #218. I reviewed it and realized another bug was looming that caused the panic. Because, there should never be a case where a parameter key is present in URLParams, but a matching param value wouldn't be available, so I knew something was wrong there.

I debugged it and found and decided that the router should return a 404 instead of matching the handler with an empty param value, because in the case, it does not correctly match the regexp \d+ pattern and even if it was just a normal param, it still doesnt make sense to match it.

chi/mux_test.go

Line 1290 in 7eca4e6

if _, body := testRequest(t, ts, "GET", "/user/", nil); body != "nothing here" {

[dvic]

Nice catch!