Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WAYLAND_DISPLAY instead of nonstandard XDG_SESSION_TYPE #797

Closed
yukawa opened this issue Aug 26, 2023 · 0 comments
Closed

Use WAYLAND_DISPLAY instead of nonstandard XDG_SESSION_TYPE #797

yukawa opened this issue Aug 26, 2023 · 0 comments

Comments

@yukawa
Copy link
Collaborator

yukawa commented Aug 26, 2023

Description

While we've been checking if XDG_SESSION_TYPE environment variable is wayland or not to check whether the ibus-mozc is running under Wayland session or not for long time since 2d39bb4 for #431, it seems that XDG_SESSION_TYPE is just a convention invented by systemd forks, and may not be set.

Let's use WAYLAND_DISPLAY instead for simplicity and better compatibility.

Version or commit-id

89c7008

Environment

  • OS: Linux all
  • IMF: Only affects ibus-mozc
coooooooozy pushed a commit to coooooooozy/mozc that referenced this issue Nov 26, 2023
@yukawa @coooooooozy
Fix google#797: Check WAYLAND_DISPLAY instead of XDG_SESSION_TYPE
9ca3836 
Despite its name, 'XDG_SESSION_TYPE' is not a part of XDG. Let's check
`WAYLAND_DISPLAY` instead to determine whether ibus-mozc is running
under Wayland session or not.

PiperOrigin-RevId: 560356898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yukawa