Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove third_party/ipa_font #842

Closed
yukawa opened this issue Nov 4, 2023 · 1 comment
Closed

Remove third_party/ipa_font #842

yukawa opened this issue Nov 4, 2023 · 1 comment

Comments

@yukawa
Copy link
Collaborator

yukawa commented Nov 4, 2023

Description

Files under third_party/ipa_font are currently used only from the rendering test for Windows.

bool WinFontTestHelper::Initialize() {
if (g_ipa_gothic_ == nullptr) {
const std::string path = testing::GetSourceFileOrDie(
{"..", "..", "..", "third_party", "ipa_font", "ipaexg.ttf"});
g_ipa_gothic_ = LoadPrivateFont(win32::Utf8ToWide(path).c_str());
}
if (g_ipa_mincho_ == nullptr) {
const std::string path = testing::GetSourceFileOrDie(
{"..", "..", "..", "third_party", "ipa_font", "ipaexm.ttf"});
g_ipa_mincho_ = LoadPrivateFont(win32::Utf8ToWide(path).c_str());
}
if (g_ipa_gothic_ == nullptr || g_ipa_mincho_ == nullptr) {
Uninitialize();
return false;
}
return true;
}

In theory, a simple font that only contains a single glyph for A should be sufficient for our use cases.

Let's create our own test font and update our tests to use it so that we can reduce our third party dependencies.

Version or commit-id

ddd9730

hiroyuki-komatsu pushed a commit that referenced this issue Nov 6, 2023
This commit adds our own test font that contains a single glyph for 'A'
then update existing font rendering tests and golden data accordingly.

With this commit, we can remove the dependency on third_party/ipa_font.

#codehealth

PiperOrigin-RevId: 579727092
@hiroyuki-komatsu
Copy link
Collaborator

b82b8de removed third_party/ipa_font.

hiroyuki-komatsu added a commit that referenced this issue Nov 15, 2023
Typing quality
* Updated the word dictionary.
* Adjusted the conversion with suffix numbers (e.g. 後に vs あと2).

Windows
* Prelaunch processes from the installer (#845)

Build
* Updated the Protobuf version: v24.2 → v25.0 (#841)
* Updated the Abseil version: 20230125.3 → 20230802.1 (#841)
* Supported to follow updates of external environmental dependencies (#843, #844)
* Removed `third_party/ipa_font` and introduced our own testing font  (#842)
* Android: Fixed the linkage error of Android library build (#840)

PiperOrigin-RevId: 582509744
coooooooozy pushed a commit to coooooooozy/mozc that referenced this issue Nov 26, 2023
This commit adds our own test font that contains a single glyph for 'A'
then update existing font rendering tests and golden data accordingly.

With this commit, we can remove the dependency on third_party/ipa_font.

#codehealth

PiperOrigin-RevId: 579727092
coooooooozy pushed a commit to coooooooozy/mozc that referenced this issue Nov 26, 2023
Typing quality
* Updated the word dictionary.
* Adjusted the conversion with suffix numbers (e.g. 後に vs あと2).

Windows
* Prelaunch processes from the installer (google#845)

Build
* Updated the Protobuf version: v24.2 → v25.0 (google#841)
* Updated the Abseil version: 20230125.3 → 20230802.1 (google#841)
* Supported to follow updates of external environmental dependencies (google#843, google#844)
* Removed `third_party/ipa_font` and introduced our own testing font  (google#842)
* Android: Fixed the linkage error of Android library build (google#840)

PiperOrigin-RevId: 582509744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants