-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converting a string of -
and digits less than three to half-width causes crashes
#878
Comments
I found the error log.
|
Hi kahunsyo, Thank you for the report with logs. It's very helpful for investigations. Looking at the log, the crash happens in src/mac/GoogleJapaneseInputController.mm. Best, |
Hi kahunsyo, I tried to reproduce the issue, but this issue doesn't happen in my environment (M1 Mac Mini). Would you confirm if this issue still happens with the latest version, and also following things?
It'd be great if screen records are available. |
Hi, hiroyuki-komatsu! I missed precise steps and my settings. I tried to uninstall mozc with After that, I reinstalled Mozc with The crash still happens. I found that when I convert a string of If I create a segment of string in question, crashes occur too. Below steps are precise step and another step. Precise step
Crashes did't occur in When I submitted New situation: extending segment
The video shows this. The crash occurs around 0:30. video-1.movThank you, |
I forgot answering your questions.
May be all.
MS-IME or custom (mentioned above)
Yes, default with MS-IME (mentioned above) |
Thank you so much for your detailed information with the screen record. I have succeeded to reproduce this issue. Best, |
* Fixed DateRewriter::IsNDigits to exclude negative values. * #878 #codehealth PiperOrigin-RevId: 633099245
Hi kahunsyo, ba8751c is the fix of this issue. Would you confirm if it works on your environment? FYI.
We have addressed / will address those issues too. |
Thank you so much for your commit. I tried in my mac. Thank you, |
Features * Added more symbol characters (#933) * Added words of 対象内 / 対象外 by fixing the format error (#928) Bug fix * Fixed the crash issue on saving the user dictionary. (42cbb3f) * Fixed the crash issue on the debug build caused by converting negative numbers (#878) * macOS: Replaced "Google Japanese Input" with Mozc in UI messages. (caeb9ce) * macOS: Fixed the crash issue of mozc_emacs_helper (#900) * macOS (Apple Silicon): Fixed the crash issue of GUI tools (#791) Build * Set proper release/debug build options for GitHub Actions (07c5f89) * Updated the Protobuf version: v26.1 → v27.0 (#937) * Updated the Qt version: 6.7.0 → 6.7.1 (#934) * Linux: Added Dockerfile for Ubuntu 24.04 (#924) * Windows: Simplified the build process by reducing manual execution of the vcvars .bat file. (#923) Code * Applied Clang's build cleaner * Completed the migration from base/logging.h to Abseil log. * macOS: Applied suggestions from code scanning alerts (b955086) PiperOrigin-RevId: 639975159
Description
Converting a string of
-
and digits less than three to half-width causes crashes.Steps to reproduce
Steps to reproduce the behavior:
−123
with IMEExpected behavior
You can convert full-width strings to half-width.
Actual behavior
IME stacks in around 30s and crash.
Version or commit-id
Mozc-2.29.5374.101+24.11.oss
build for apple silicon
Environment
Investigations
(e.g. Mozc-2.28.4960.100+24.11.oss).
The text was updated successfully, but these errors were encountered: