Add/improve various symbols #933
Conversation
|
I wonder when we should edit |
src/data/symbol/symbol.tsv
Outdated
| 記号 ≤ ふとうごう しょうなりいこーる すうがく < <= きごう 不等号 海外 SYMBOL | ||
| 記号 ≥ ふとうごう だいなりいこーる すうがく > >= きごう 不等号 海外 SYMBOL | ||
| 記号 ⩽ ふとうごう しょうなりいこーる すうがく < <= きごう 不等号 海外 SYMBOL | ||
| 記号 ⩾ ふとうごう だいなりいこーる すうがく > >= きごう 不等号 海外 SYMBOL |
There was a problem hiding this comment.
I guess these 海外 symbols are not so popular, but confusing with ≦ and ≧.
How about removing them?
There was a problem hiding this comment.
We can frequently find them in higher education even in Japan, I think.
"大学" or "大学・海外" instead of "海外" might be better.
Do you still think they're unnecessary?
There was a problem hiding this comment.
Do you still think they're unnecessary?
I don't say they are unnecessary, but given that those we often use these characters can easily add them into user dictionary, I'd say the urgency is not that high. Actually, I'm more interested in how we can improve our candidate window UX as we keep increasing number of candidate, but it'd be a different story (*).
(*): Try to convert えもじ or きごう. I feel the number of candidates is already way too big. We even hit #741 because of that.
There was a problem hiding this comment.
(*)
I guessed it. I'll remove "きごう" from the following symbols because they'll not be wanted by those who try to input symbols by "きごう".
- the above 4 inequality symbols
- mathematical dots
I don't know whether we should do the same for:
- ∓
- en dash
- (em dash) (would need almost always to be used instead of U+2015 if Windows didn't exist)
There was a problem hiding this comment.
the above 4 inequality symbols
For those 4 inequality symbols, I'd suggest not including into this PR at least until we come up with a better description. For people who have never used those characters, I guess "大学", "大学・海外" and "海外" are all hard to understand what the description tried to explain. Let's revisit them later, e.g. 1 year later for example. Again, I don't think adding them are not that urgent.
There was a problem hiding this comment.
Removed it as you wish.
Also removed "きごう" from mathematical dots because they're not in JIS X 0213.
I found both dashes and ∓ are all in JIS X 0213, so I thought I don't have to remove "きごう" from them.
I got it. I'll revert their changes. |
|
Thank you for updating the change! It looks good to me too. After some actual experiences, we might adjust some entries or orders in future. |
Features * Added more symbol characters (#933) * Added words of 対象内 / 対象外 by fixing the format error (#928) Bug fix * Fixed the crash issue on saving the user dictionary. (42cbb3f) * Fixed the crash issue on the debug build caused by converting negative numbers (#878) * macOS: Replaced "Google Japanese Input" with Mozc in UI messages. (caeb9ce) * macOS: Fixed the crash issue of mozc_emacs_helper (#900) * macOS (Apple Silicon): Fixed the crash issue of GUI tools (#791) Build * Set proper release/debug build options for GitHub Actions (07c5f89) * Updated the Protobuf version: v26.1 → v27.0 (#937) * Updated the Qt version: 6.7.0 → 6.7.1 (#934) * Linux: Added Dockerfile for Ubuntu 24.04 (#924) * Windows: Simplified the build process by reducing manual execution of the vcvars .bat file. (#923) Code * Applied Clang's build cleaner * Completed the migration from base/logging.h to Abseil log. * macOS: Applied suggestions from code scanning alerts (b955086) PiperOrigin-RevId: 639975159
Description
A clear and concise description of this pull request.
Added/improved symbols composition:
合成用濁点・半濁点Issue IDs
Issue and/or discussion IDs related to this pull request.
#929
Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
Additional context
Add any other context about the pull request here.
I split commits according to symbol types.