-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proto/profile.proto: fix typo #577
Conversation
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
- Coverage 66.97% 66.96% -0.02%
==========================================
Files 78 78
Lines 14160 14160
==========================================
- Hits 9484 9482 -2
- Misses 3842 3843 +1
- Partials 834 835 +1
Continue to review full report at Codecov.
|
proto/profile.proto
Outdated
@@ -109,7 +109,7 @@ message Sample { | |||
// entry in Profile.sample_type. All samples must have the same | |||
// number of values, the same as the length of Profile.sample_type. | |||
// When aggregating multiple samples into a single sample, the | |||
// result has a list of values that is the elemntwise sum of the | |||
// result has a list of values that is the elementwise sum of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it "element-wise"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ changed
5314cf0
to
2dfc5ed
Compare
Ping! It's not like the world would stop without this fixed, but can we just merge it? 😃 |
Thanks 🍰 |
I actually haven't merged, I only rebased :) Some tests are failing for some reason. |
@aalexand yeah but you've reacted 😉 thanks for that. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@srenatus CLA check fails now for some reason. Do you have the CLA signed? |
@aalexand I've switched jobs and thus changed my primary email on github. I'll follow up on this issue! Sorry for delaying this. |
@aalexand Is there anything I can do to re-trigger a CLA check? I think it should be sorted now. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Restarted checks after #580 is merged. |
@srenatus Please follow the instructions from @google-cla bot in #577 (comment) to sign the CLA. |
Signed-off-by: Stephan Renatus <[email protected]>
eb3f216
to
653e7ae
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@srenatus CLA bot is still not able to verify that you signed it. PR cannot be merged until it is signed. |
@kalyanac thanks, I'll try to take care of this. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@srenatus CLA bot is still not able to verify that you signed it. PR cannot be merged until it is signed. |
@kalyanac yeah it's on us. We're looking into it. Please bear with me 😄 |
@googlebot I signed it! |
Fiiinaaaalllly 🎉 |
No description provided.