Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto/profile.proto: fix typo #577

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Conversation

srenatus
Copy link
Contributor

@srenatus srenatus commented Nov 5, 2020

No description provided.

@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #577 (de610f2) into master (3dbeb62) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   66.97%   66.96%   -0.02%     
==========================================
  Files          78       78              
  Lines       14160    14160              
==========================================
- Hits         9484     9482       -2     
- Misses       3842     3843       +1     
- Partials      834      835       +1     
Impacted Files Coverage Δ
.../github.com/google/pprof/internal/report/source.go 80.76% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbeb62...de610f2. Read the comment docs.

kalyanac
kalyanac previously approved these changes Nov 5, 2020
@@ -109,7 +109,7 @@ message Sample {
// entry in Profile.sample_type. All samples must have the same
// number of values, the same as the length of Profile.sample_type.
// When aggregating multiple samples into a single sample, the
// result has a list of values that is the elemntwise sum of the
// result has a list of values that is the elementwise sum of the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it "element-wise"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ changed

@srenatus
Copy link
Contributor Author

Ping! It's not like the world would stop without this fixed, but can we just merge it? 😃

@srenatus
Copy link
Contributor Author

Thanks 🍰

@aalexand
Copy link
Collaborator

Thanks 🍰

I actually haven't merged, I only rebased :) Some tests are failing for some reason.

@srenatus
Copy link
Contributor Author

@aalexand yeah but you've reacted 😉 thanks for that.

@google-cla
Copy link

google-cla bot commented Nov 16, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 16, 2020
@aalexand
Copy link
Collaborator

@srenatus CLA check fails now for some reason. Do you have the CLA signed?

@srenatus
Copy link
Contributor Author

srenatus commented Nov 17, 2020

@aalexand I've switched jobs and thus changed my primary email on github. I'll follow up on this issue! Sorry for delaying this.

@srenatus
Copy link
Contributor Author

@aalexand Is there anything I can do to re-trigger a CLA check? I think it should be sorted now.

@google-cla
Copy link

google-cla bot commented Nov 17, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kalyanac
Copy link
Contributor

Restarted checks after #580 is merged.

@kalyanac
Copy link
Contributor

kalyanac commented Nov 17, 2020

@srenatus Please follow the instructions from @google-cla bot in #577 (comment) to sign the CLA.

Signed-off-by: Stephan Renatus <[email protected]>
@google-cla
Copy link

google-cla bot commented Nov 18, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kalyanac
Copy link
Contributor

kalyanac commented Nov 18, 2020

@srenatus CLA bot is still not able to verify that you signed it. PR cannot be merged until it is signed.

@srenatus
Copy link
Contributor Author

@kalyanac thanks, I'll try to take care of this.

@google-cla
Copy link

google-cla bot commented Dec 16, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kalyanac
Copy link
Contributor

@srenatus CLA bot is still not able to verify that you signed it. PR cannot be merged until it is signed.

@srenatus
Copy link
Contributor Author

@kalyanac yeah it's on us. We're looking into it. Please bear with me 😄

@srenatus
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot removed the cla: no label Jan 15, 2021
@google-cla google-cla bot added the cla: yes label Jan 15, 2021
@srenatus
Copy link
Contributor Author

Fiiinaaaalllly 🎉

@kalyanac kalyanac merged commit 39141e7 into google:master Jan 15, 2021
@srenatus srenatus deleted the sr/typo/profile.proto branch January 16, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants