ClickHouse Database datasource plugin update to 2.2.0

[Slach]

2.2.0 (2020-11-30)

Enhancement:

• add region support to annotation query, try to fix wrong column orders for table format, fix [Feature Request] Annotation Region Support Altinity/clickhouse-grafana#303
• add plugin sign process, fix Implements sign process and add dist/MANIFEST.txt  Altinity/clickhouse-grafana#212
• add DateTime64 support, fix DateTime64 Support Altinity/clickhouse-grafana#292
• add linux\arm64 backend plugin build
• improve ARRAY JOIN parsing, fix no generate select 2.1 Altinity/clickhouse-grafana#284
• improve docker-compose.yaml add ability to redefine GRAFANA_VERSION and CLICKHOUSE_VERSION via environment variables latest by default

Fixes:

• add *.js.map and *.js from src and spec folder to .gitignore
• don't apply adhoc filters twice when used $adhoc macros, fix adhoc is not working in latest grafana and latest plugin Altinity/clickhouse-grafana#282
• fix corner case for table format with wrong columns order between meta and data response section, fix Tables have wrong columns if ClickHouse JSON datapoint is not ordered Altinity/clickhouse-grafana#281
• add trickster to docker-compose environment
• actualize links in README.md

Signed-off-by: Eugene Klimov [email protected]

[marcusolsson]

Hi @Slach,

Since Grafana 7.3, we've changed how we package plugins. For more information, refer to Package a plugin.

You can enter the URL to the plugin archive in the plugin validator to see if it's ready to be published. Let me know if you have any questions!

[Slach]

@marcusolsson please look at this PR again, currently, all plugin-validator checks passed

[Slach]

@marcusolsson any news about this Pull Request?

[Slach]

@marcusolsson please merge this pull request

[Slach]

@marcusolsson could you look at this PR again?
anything else that I should do to able this PR to merge?

[marcusolsson]

Hi @Slach,

Just got back from the holidays 👋 Will take a look at this in the coming days!

[marcusolsson]

It looks like you're affected by a bug in the sign command where grafana-toolkit generates invalid paths in the MANIFEST.txt (I believe this bug appears when running the sign command on a Windows machine). For more information, refer to #798 (comment).

Could you please update the manifest with the changes listed below?

In the MANIFEST.txt, change the double backslash, \\, in the file names to a forward slash, /.

For example, change:

"img\\annotations.png": "09cc19df992fede5c4dd830f7b3c7a783702feced07ea9693d417ec127077b00",

into

"img/annotations.png": "09cc19df992fede5c4dd830f7b3c7a783702feced07ea9693d417ec127077b00",

[Slach]

@marcusolsson done
please check and merge pull request

[Slach]

@marcusolsson
https://app.circleci.com/pipelines/github/grafana/grafana-plugin-repository/776/workflows/1f099572-d903-4a7f-8b3a-2ac101f17731/jobs/2957/parallel-runs/0/steps/0-105

what exactly means "README.md not found"
where exactly your tool try to find README.md?
it already exists in fresh uploaded ZIP file

[Slach]

@marcusolsson and README.md already contains in github https://github.com/Vertamedia/clickhouse-grafana/tree/67e5b7f80cfe5198db9ac8fdabfe2d70c7f2aaa1

[marcusolsson]

I can see that you've fixed the MANIFEST file. Unfortunately, I'm still getting a warning about a "Modified signature" when I try to load it.

I think the errors are due to an unsupported archive structure. It looks like the plugin assets are located at the root of the ZIP archive instead of in a directory named as the plugin ID.

Could you verify that you've packaged your plugin according to the instructions on Package a plugin, i.e.:

yarn build
mage
mv dist/ vertamedia-clickhouse-datasource
zip vertamedia-clickhouse-datasource-2.2.0.zip vertamedia-clickhouse-datasource -r

For future reference, I recommend that you take a look at the GitHub Actions for building, testing, and packaging plugins. It should make life easier :)

[Slach]

@marcusolsson done

please merge

[Slach]

@marcusolsson could you suggest when a bug in the signing process will fix and npx @grafana/toolkit plugin:sign will work properly in all OSes?

[marcusolsson]

Thank you for your patience and for fixing the issues so quickly! I can confirm that the plugin is packaged correctly. Marking this as ready for review. You can see your current position in the review queue on the project board.

I'm not aware of a fix at the moment, but I will check with the plugin team tomorrow for when this can be fixed.

[marcusolsson]

Published! 🎉

[marcusolsson]

@Slach FYI, here's the pull request for the issue with the invalid MANIFEST.txt: grafana/grafana#30287

[Slach]

@marcusolsson thanks a lot for suggestion