Fix checking the wrong error when initing collectors #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na--
approved these changes
Apr 28, 2020
ankur22
added a commit
that referenced
this pull request
Sep 13, 2024
ankur22
added a commit
that referenced
this pull request
Sep 17, 2024
olegbespalov
added a commit
that referenced
this pull request
Sep 30, 2024
* v0.54.0 release notes from template * Add browser#1406 to v0.54.0 release notes * Add release notes for experimental csv module * Oleg's changelog * External contributors' changelog * Minor alignments of release notes * Add browser#1420 & browser#1421 to release notes * Joan's changelog * Breaking changes, minor adjustments * Extract gRPC updates under the feature * Add setChecked to release notes * Add file upload protocol to release notes * Add browser#1408 & #1422 to release notes * mstoykov: most of my release notes changes * Add notes specific to --local-execution * Improve browser release notes Co-authored-by: Ankur <[email protected]> * Add branding changes * add usage changes to release notes * xk6-websockets changes * Add browser module notice * Add future plans notice back * Fix regex code block release notes * Fix doc next links to latest * Add setChecked links * Add async check utility * Fix k6lib check next to latest * Improve async check notes Co-authored-by: Ankur <[email protected]> * Improve browser release notes Co-authored-by: Heitor Tashiro Sergent <[email protected]> * Apply suggestions from code review Co-authored-by: Heitor Tashiro Sergent <[email protected]> * Adding missing dependencies PRs, aligning the style * Mention further bug fixes and maintenance work * Apply suggestions from code review Co-authored-by: Andrey Slotin <[email protected]> * Add fix browser#1435 * Apply suggestions from code review Co-authored-by: Mihail Stoykov <[email protected]> Co-authored-by: Heitor Tashiro Sergent <[email protected]> * Add most recent browser related fixes * Apply suggestions from code review Co-authored-by: Heitor Tashiro Sergent <[email protected]> * Apply code review suggestions, mentioning new PRs * Apply suggestions from code review Co-authored-by: Heitor Tashiro Sergent <[email protected]> * Apply suggestions from code review Co-authored-by: Mihail Stoykov <[email protected]> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Joan López de la Franca Beltran <[email protected]> --------- Co-authored-by: ankur22 <[email protected]> Co-authored-by: oleiade <[email protected]> Co-authored-by: Joan López de la Franca Beltran <[email protected]> Co-authored-by: İnanç Gümüş <[email protected]> Co-authored-by: Mihail Stoykov <[email protected]> Co-authored-by: Heitor Tashiro Sergent <[email protected]> Co-authored-by: Andrey Slotin <[email protected]> Co-authored-by: Mihail Stoykov <[email protected]> Co-authored-by: Joan López de la Franca Beltran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.