-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudv2: Downscale the batch size #3193
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3193 +/- ##
==========================================
+ Coverage 72.85% 72.87% +0.02%
==========================================
Files 256 256
Lines 19803 19804 +1
==========================================
+ Hits 14428 14433 +5
+ Misses 4474 4471 -3
+ Partials 901 900 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding a comment explaining why we set it too 1000 directly in the code, as you explained here, but not blocking 👍🏻
@oleiade good idea |
611e64b
to
c43ba7f
Compare
@olegbespalov added you to make sure you're aware of the change. We don't require anymore to set this option in our operations because the default already matches the requirement. |
The backend has the limit set to 1k so it doesn't make sense to use a bigger value forcing the system to split a single batch in multiple jobs.
c43ba7f
to
d4479c0
Compare
The backend has the limit set to 1k so it doesn't make sense to use a bigger value forcing the system to split a single batch in multiple jobs.
We are already overwriting the default value for most of the cases. This PR removes the requirement for setting the env var for doing the overwrite simplifing internal operations.