Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes v0.46.0 #3246

Merged
merged 35 commits into from
Aug 14, 2023
Merged

Release notes v0.46.0 #3246

merged 35 commits into from
Aug 14, 2023

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Aug 3, 2023

What?

This Pull Request bumps k6's version and updates release notes for the upcoming version 0.46.

Related PR(s)/Issue(s)

#3138
https://github.com/grafana/k6/milestone/36
DefinitelyTyped/DefinitelyTyped#66271

@oleiade oleiade added the documentation-needed A PR which will need a separate PR for documentation label Aug 3, 2023
@oleiade oleiade added this to the v0.46.0 milestone Aug 3, 2023
@oleiade oleiade self-assigned this Aug 3, 2023
@github-actions github-actions bot requested review from codebien and mstoykov August 3, 2023 09:22
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #3246 (c3a1de8) into master (8fa0e6b) will not change coverage.
The diff coverage is n/a.

❗ Current head c3a1de8 differs from pull request most recent head cd9424a. Consider uploading reports for the commit cd9424a to get more accurate results

@@           Coverage Diff           @@
##           master    #3246   +/-   ##
=======================================
  Coverage   73.21%   73.21%           
=======================================
  Files         258      258           
  Lines       19884    19884           
=======================================
  Hits        14559    14559           
  Misses       4402     4402           
  Partials      923      923           
Flag Coverage Δ
ubuntu 73.10% <ø> (-0.06%) ⬇️
windows 73.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Show resolved Hide resolved
@codebien codebien changed the title Release notes v046 Release notes v0.46.0 Aug 10, 2023
@oleiade
Copy link
Member Author

oleiade commented Aug 10, 2023

Note that the PR is red because it hasn't been rebased on master (containing the go.buf.build fix yet). Will rebase before the merge at the time of the release.

lib/consts/consts.go Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
@codebien
Copy link
Contributor

Note that the PR is red because it hasn't been rebased on master (containing the go.buf.build fix yet).

@oleiade Considering how critical it is and the impact it would generate an eventual error, I would prefer if we do it as soon as the browser merged their PR.

release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleiade I believe we're missing at least two things that are going to land in this release, probably, since their PRs have no milestones assigned 😢

But it's still worth mentioning them:

@oleiade oleiade force-pushed the release-notes-v046 branch from 0f70c94 to ccbae7f Compare August 11, 2023 12:57
@oleiade
Copy link
Member Author

oleiade commented Aug 11, 2023

I have forced push to integrate the changes from master, and make the branch 🍏 again. Please make sure to git pull --rebase your local copy before you add any changes.

@olegbespalov can you add the changes you mentioned? 🙏🏻 I'm trying to wrap up my hackathon, so any support here is welcome 👍🏻

@olegbespalov
Copy link
Contributor

@oleiade Sorry, I was wrapping some technical debt and have no capacity for doing this today, and I'm off on Monday/Tuesday, if you can't make changes too, please explicitly ask team for help in Slack

@oleiade
Copy link
Member Author

oleiade commented Aug 11, 2023

No worries, I'm busy hacking at the moment. I'll bring the changes in on monday.

Copy link
Contributor

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is normal but it feels like a big release! I left a few comments, mostly small nits or rewriting sentences for clarity, and removing some of the template stuff. I also included a suggestion for the first section, I looked at a few previous release notes, but feel free to ignore/edit that. 😄

release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
release notes/v0.46.0.md Outdated Show resolved Hide resolved
Copy link
Contributor

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is normal but it feels like a big release! I left a few comments, mostly small nits or rewriting sentences for clarity, and removing some of the template stuff. I also included a suggestion for the first section, I looked at a few previous release notes, but feel free to ignore/edit that. 😄

@oleiade
Copy link
Member Author

oleiade commented Aug 14, 2023

I've added a mention of the two issues that @olegbespalov brought up 👍🏻

release notes/v0.46.0.md Outdated Show resolved Hide resolved
@oleiade oleiade requested a review from codebien August 14, 2023 08:58
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@mstoykov mstoykov dismissed olegbespalov’s stale review August 14, 2023 11:09

it has been addressed

@oleiade oleiade merged commit a269641 into master Aug 14, 2023
@oleiade oleiade deleted the release-notes-v046 branch August 14, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-needed A PR which will need a separate PR for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.