-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve release issue template #3275
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3275 +/- ##
==========================================
+ Coverage 73.19% 73.22% +0.03%
==========================================
Files 258 258
Lines 19884 19884
==========================================
+ Hits 14555 14561 +6
+ Misses 4405 4400 -5
+ Partials 924 923 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Ivan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general - I mostly disagree with having the docs PR merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
What?
This PR fixes the grammar of the release checklist, and revamps it a bit to address the unclarities I experienced when using it for the
v0.46.0
release.Why?
The last item of the checklist is about bringing improvements to the checklist if possible, so I've given it a shot.
I found the language of the checklist could be improved to make it easier to read, and I experienced difficulties at times really understanding what I needed to do. Although I believe some further improvements would still be possible.
PS: I've also toyed with a much more concise and direct style, just like in aviation checklists, maybe that's even better?