Ensure logger is provided #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewnolf
approved these changes
Jan 7, 2022
ferruvich
approved these changes
Jan 7, 2022
|
I'm still planning to submit PR's for all of this upstream after I get things tested. |
|
Thinking about it a bit more, I'm going to remove the renames from this PR since they are unrelated and are likely to cause more conflicts upstream. |
644cce3
to
9896146
Compare
9896146
to
86a04a5
Compare
cristiangreco
pushed a commit
that referenced
this pull request
Apr 1, 2022
* Pass logger to the different structs * Use a builder for the AWS services * Use job specific loggers to propagate properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started by fixing an issue where the logger wasn't being passed to the two AWS "interface" structs. I created some factory functions to use which should hopefully be more helpful vs the nil pointer crashes I got in dev.
I also did some renames for clarity on the AWS adapters and took a pass for structured logging so logs should have the same properties now.