-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Limit Result Format and QueryMetricProvider
total unexpected records
#10432
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10432 +/- ##
===========================================
+ Coverage 79.97% 80.07% +0.10%
===========================================
Files 461 461
Lines 40000 39993 -7
===========================================
+ Hits 31988 32023 +35
+ Misses 8012 7970 -42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
UnexpectedRowsQuery
limit metric result setQueryMetricProvider
total unexpected records
QueryMetricProvider
total unexpected recordsQueryMetricProvider
total unexpected records
…t-expectations/great_expectations into b/ph-1599/unexpected-rows-query-oom
:::note | ||
`include_unexpected_rows` returns EVERY row for each unexpected value. In large tables, this could result in an unmanageable amount of data. | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All I did was remove this note. Not sure why the diffs are hard to read.
QueryMetricProvider
unexpected recordsQueryMetricProvider
invoke lint
(usesruff format
+ruff check
)