-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Add public-api
check back to CI
#10449
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10449 +/- ##
===========================================
- Coverage 80.09% 80.09% -0.01%
===========================================
Files 461 461
Lines 39995 39995
===========================================
- Hits 32035 32033 -2
- Misses 7960 7962 +2 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…_expectations into m/core-315/bring_back_public_api_ci
…_expectations into m/core-315/bring_back_public_api_ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda stressed about all the new stuff. Some of it seems like it just needs to be added to the @public_api
, and some seems like a mistake. But we need this check running again, so I think we should merge ASAP and cleanup after.
Undoing #9587
invoke lint
(usesruff format
+ruff check
)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!