Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add dynamic parameters documentation #10483

Merged
merged 6 commits into from
Nov 2, 2024

Conversation

annabarr
Copy link
Contributor

@annabarr annabarr commented Oct 8, 2024

https://greatexpectations.atlassian.net/browse/ZELDA-1012

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 196ebe4
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/67256c7bff0182000824290f

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.31%. Comparing base (87037ee) to head (196ebe4).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10483   +/-   ##
========================================
  Coverage    80.31%   80.31%           
========================================
  Files          463      463           
  Lines        40116    40116           
========================================
  Hits         32221    32221           
  Misses        7895     7895           
Flag Coverage Δ
3.10 68.03% <ø> (ø)
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 clickhouse ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark_connect ?
3.10 trino ?
3.11 68.02% <ø> (-0.02%) ⬇️
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 clickhouse ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark_connect ?
3.11 trino ?
3.12 68.03% <ø> (ø)
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 55.41% <ø> (ø)
3.12 aws_deps 46.15% <ø> (ø)
3.12 big 54.75% <ø> (ø)
3.12 databricks 47.88% <ø> (ø)
3.12 filesystem 61.71% <ø> (ø)
3.12 mssql 50.25% <ø> (ø)
3.12 mysql 50.32% <ø> (ø)
3.12 postgresql 54.63% <ø> (ø)
3.12 snowflake 48.80% <ø> (ø)
3.12 spark 58.06% <ø> (ø)
3.12 spark_connect 46.44% <ø> (ø)
3.12 trino 52.68% <ø> (ø)
3.9 68.07% <ø> (ø)
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 55.41% <ø> (ø)
3.9 aws_deps 46.17% <ø> (ø)
3.9 big 54.77% <ø> (ø)
3.9 clickhouse 43.03% <ø> (ø)
3.9 databricks 47.90% <ø> (ø)
3.9 filesystem 61.73% <ø> (ø)
3.9 mssql 50.24% <ø> (ø)
3.9 mysql 50.30% <ø> (ø)
3.9 postgresql 54.62% <ø> (ø)
3.9 snowflake 48.82% <ø> (ø)
3.9 spark 58.03% <ø> (ø)
3.9 spark_connect 46.45% <ø> (ø)
3.9 trino 52.66% <ø> (ø)
cloud 0.00% <ø> (ø)
docs-basic 53.36% <ø> (ø)
docs-creds-needed 52.93% <ø> (ø)
docs-spark 52.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annabarr annabarr requested a review from shiplet October 8, 2024 16:48
Copy link
Contributor

@r34ctor r34ctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small comments, but otherwise this looks great!


- There are `n` runs, the Expectation will take the last `n` runs into account.

- There are `>n` runs, the Expectation will take the last `n` runs into account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest also adding a line here to describe what "Strict" does.

@annabarr annabarr removed the request for review from shiplet November 1, 2024 22:27
@annabarr annabarr added this pull request to the merge queue Nov 2, 2024
Merged via the queue into develop with commit 424d9cf Nov 2, 2024
65 checks passed
@annabarr annabarr deleted the d/zelda-1012/dynamic-params branch November 2, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants