Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Remove result_url from CheckpointResult #10493

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

cdkini
Copy link
Contributor

@cdkini cdkini commented Oct 9, 2024

Unused attribute

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 969a7f3
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/67069a823b59f500087c4920

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.09%. Comparing base (251d6d9) to head (969a7f3).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ns/data_context/data_context/cloud_data_context.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10493      +/-   ##
===========================================
- Coverage    80.09%   80.09%   -0.01%     
===========================================
  Files          461      461              
  Lines        39976    39976              
===========================================
- Hits         32020    32018       -2     
- Misses        7956     7958       +2     
Flag Coverage Δ
3.10 67.70% <0.00%> (-0.01%) ⬇️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 spark_connect ?
3.10 trino ?
3.11 67.70% <0.00%> (-0.02%) ⬇️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 databricks ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 snowflake ?
3.11 spark ?
3.11 spark_connect ?
3.11 trino ?
3.12 66.34% <0.00%> (-0.01%) ⬇️
3.12 aws_deps 45.94% <0.00%> (-0.01%) ⬇️
3.12 big 54.58% <0.00%> (-0.01%) ⬇️
3.12 filesystem 61.51% <0.00%> (-0.01%) ⬇️
3.12 mssql 50.05% <0.00%> (-0.01%) ⬇️
3.12 mysql 50.11% <0.00%> (-0.01%) ⬇️
3.12 postgresql 54.40% <0.00%> (-0.01%) ⬇️
3.12 spark 57.89% <0.00%> (-0.01%) ⬇️
3.12 spark_connect 46.24% <0.00%> (-0.01%) ⬇️
3.12 trino 52.49% <0.00%> (-0.01%) ⬇️
3.9 67.74% <0.00%> (-0.01%) ⬇️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 55.21% <0.00%> (-0.01%) ⬇️
3.9 aws_deps 45.96% <0.00%> (-0.01%) ⬇️
3.9 big 54.59% <0.00%> (-0.01%) ⬇️
3.9 databricks 47.70% <0.00%> (-0.01%) ⬇️
3.9 filesystem 61.53% <0.00%> (-0.01%) ⬇️
3.9 mssql 50.03% <0.00%> (-0.01%) ⬇️
3.9 mysql 50.09% <0.00%> (-0.01%) ⬇️
3.9 postgresql 54.38% <0.00%> (-0.01%) ⬇️
3.9 snowflake 48.55% <0.00%> (-0.01%) ⬇️
3.9 spark 57.85% <0.00%> (-0.01%) ⬇️
3.9 spark_connect 46.26% <0.00%> (-0.01%) ⬇️
3.9 trino 52.48% <0.00%> (-0.01%) ⬇️
cloud 0.00% <0.00%> (ø)
docs-basic 52.58% <0.00%> (-0.01%) ⬇️
docs-creds-needed 52.80% <0.00%> (-0.01%) ⬇️
docs-spark 52.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cdkini cdkini added this pull request to the merge queue Oct 9, 2024
Merged via the queue into develop with commit fe35752 Oct 9, 2024
66 checks passed
@cdkini cdkini deleted the m/_/remove_result_url_from_checkpoint_result branch October 9, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants