Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Change href from relative path to root in API docs (version 0.18) #10507

Merged
merged 86 commits into from
Oct 21, 2024

Conversation

deborahniesz
Copy link
Contributor

@deborahniesz deborahniesz commented Oct 10, 2024

Jira Ticket

Deploy Preview

Description

Changed every dinamically generated path in an href in the API version 0.18 ( example: href="../../checkpoint/Checkpoint_class" to href="/https/github.com/docs/0.18/reference/api/checkpoint/Checkpoint_class")

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 8643736
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6712bbc6d5be710008b9d3b3
😎 Deploy Preview https://deploy-preview-10507.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.13%. Comparing base (335ad7c) to head (8643736).
Report is 24 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10507      +/-   ##
===========================================
+ Coverage    80.10%   80.13%   +0.03%     
===========================================
  Files          461      461              
  Lines        39979    39978       -1     
===========================================
+ Hits         32024    32037      +13     
+ Misses        7955     7941      -14     
Flag Coverage Δ
3.10 67.74% <ø> (+0.01%) ⬆️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 spark_connect ?
3.10 trino ?
3.11 67.74% <ø> (+0.01%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 databricks ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 snowflake ?
3.11 spark ?
3.11 spark_connect ?
3.11 trino ?
3.12 67.76% <ø> (+0.03%) ⬆️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 55.25% <ø> (?)
3.12 aws_deps 45.99% <ø> (+0.05%) ⬆️
3.12 big 54.62% <ø> (+0.04%) ⬆️
3.12 databricks 47.74% <ø> (?)
3.12 filesystem 61.54% <ø> (+0.04%) ⬆️
3.12 mssql 50.10% <ø> (+0.05%) ⬆️
3.12 mysql 50.16% <ø> (+0.05%) ⬆️
3.12 postgresql 54.44% <ø> (+0.05%) ⬆️
3.12 snowflake 48.58% <ø> (?)
3.12 spark 57.93% <ø> (+0.05%) ⬆️
3.12 spark_connect 46.29% <ø> (+0.05%) ⬆️
3.12 trino 52.54% <ø> (+0.05%) ⬆️
3.9 67.80% <ø> (+0.03%) ⬆️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 55.25% <ø> (?)
3.9 aws_deps 46.01% <ø> (+0.05%) ⬆️
3.9 big 54.63% <ø> (+0.04%) ⬆️
3.9 clickhouse 42.87% <ø> (?)
3.9 databricks 47.75% <ø> (+0.05%) ⬆️
3.9 filesystem 61.56% <ø> (+0.04%) ⬆️
3.9 mssql 50.08% <ø> (+0.05%) ⬆️
3.9 mysql 50.15% <ø> (+0.05%) ⬆️
3.9 postgresql 54.43% <ø> (+0.05%) ⬆️
3.9 snowflake 48.60% <ø> (+0.05%) ⬆️
3.9 spark 57.89% <ø> (+0.05%) ⬆️
3.9 spark_connect 46.30% <ø> (+0.05%) ⬆️
3.9 trino 52.52% <ø> (+0.05%) ⬆️
cloud 0.00% <ø> (ø)
docs-basic 52.59% <ø> (+0.03%) ⬆️
docs-creds-needed 52.82% <ø> (+0.03%) ⬆️
docs-spark 52.23% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deborahniesz deborahniesz changed the title [DOCS] WIP: change relative path to root [DOCS] Change href from relative path to root of API docs in version 0.18 Oct 18, 2024
@deborahniesz deborahniesz changed the title [DOCS] Change href from relative path to root of API docs in version 0.18 [DOCS] Change href from relative path to root in API docs (version 0.18) Oct 18, 2024
Copy link
Member

@josectobar josectobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually reviewed several links in the deploy build but there are too many. Please merge and manually test to confirm everything is working.

@deborahniesz deborahniesz added this pull request to the merge queue Oct 21, 2024
Merged via the queue into develop with commit 2551f13 Oct 21, 2024
68 checks passed
@deborahniesz deborahniesz deleted the DSB-1158_Check_404s_URLs_in_the_CI_2 branch October 21, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants