Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add redirects for old URLs that no longer exist #10516

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

JessSaavedra
Copy link
Contributor

@JessSaavedra JessSaavedra commented Oct 14, 2024

Description

A drop in the traffic of some URLs has been detected, as many URLs from previous versions that are still accessible from searches or users bookmarks. Here is the list of the highest traffic drops: https://docs.google.com/spreadsheets/d/1b71u0F2s-L_TKvINPJ19mtw5OF5ycY7QKH9C8O2l-Zs/edit?gid=163061189#gid=163061189

The purpose of this PR is to add redirection rules to prevent users from getting a 404 url and instead redirecting them to the corresponding versioned or most similar page

Video

Grabacion.de.pantalla.desde.14-10-24.20.44.04.webm
  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit f0db778
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/670fd07f5ea9ca0008fb37a6
😎 Deploy Preview https://deploy-preview-10516.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.12%. Comparing base (0b3d36f) to head (f0db778).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10516   +/-   ##
========================================
  Coverage    80.12%   80.12%           
========================================
  Files          461      461           
  Lines        39997    39997           
========================================
  Hits         32047    32047           
  Misses        7950     7950           
Flag Coverage Δ
3.10 67.75% <ø> (ø)
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 clickhouse ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark_connect ?
3.10 trino ?
3.11 67.75% <ø> (ø)
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 clickhouse ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark_connect ?
3.11 trino ?
3.12 67.75% <ø> (ø)
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 55.23% <ø> (ø)
3.12 aws_deps 45.97% <ø> (ø)
3.12 big 54.61% <ø> (ø)
3.12 databricks 47.72% <ø> (ø)
3.12 filesystem 61.53% <ø> (ø)
3.12 mssql 50.08% <ø> (ø)
3.12 mysql 50.14% <ø> (ø)
3.12 postgresql 54.42% <ø> (ø)
3.12 snowflake 48.57% <ø> (ø)
3.12 spark 57.91% <ø> (ø)
3.12 spark_connect 46.27% <ø> (ø)
3.12 trino 52.52% <ø> (ø)
3.9 67.79% <ø> (ø)
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 55.23% <ø> (ø)
3.9 aws_deps 45.99% <ø> (ø)
3.9 big 54.62% <ø> (ø)
3.9 clickhouse 42.85% <ø> (ø)
3.9 databricks 47.73% <ø> (ø)
3.9 filesystem 61.54% <ø> (ø)
3.9 mssql 50.07% <ø> (ø)
3.9 mysql 50.13% <ø> (ø)
3.9 postgresql 54.40% <ø> (ø)
3.9 snowflake 48.58% <ø> (ø)
3.9 spark 57.87% <ø> (ø)
3.9 spark_connect 46.28% <ø> (ø)
3.9 trino 52.50% <ø> (ø)
cloud 0.00% <ø> (ø)
docs-basic 52.60% <ø> (ø)
docs-creds-needed 52.82% <ø> (ø)
docs-spark 52.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JessSaavedra JessSaavedra force-pushed the DSB-1176_configure_redirect_for_old_pages branch 3 times, most recently from 837cf12 to 7b95e09 Compare October 14, 2024 21:03
@JessSaavedra JessSaavedra force-pushed the DSB-1176_configure_redirect_for_old_pages branch from 7b95e09 to d6ea334 Compare October 14, 2024 21:16
@JessSaavedra JessSaavedra force-pushed the DSB-1176_configure_redirect_for_old_pages branch from 082a7ca to 43ed95a Compare October 14, 2024 23:30
@JessSaavedra JessSaavedra changed the title [DOCS] WIP: Add redirects for version 0.18 URLs [DOCS] Add redirects for version 0.18 URLs Oct 14, 2024
@JessSaavedra JessSaavedra changed the title [DOCS] Add redirects for version 0.18 URLs [DOCS] Add redirects for old URLs that no longer exist Oct 14, 2024
@JessSaavedra JessSaavedra added this pull request to the merge queue Oct 16, 2024
Merged via the queue into develop with commit 26b118a Oct 16, 2024
64 checks passed
@JessSaavedra JessSaavedra deleted the DSB-1176_configure_redirect_for_old_pages branch October 16, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants