Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Bump ruff to 0.7.0 #10535

Merged
merged 5 commits into from
Oct 18, 2024
Merged

[MAINTENANCE] Bump ruff to 0.7.0 #10535

merged 5 commits into from
Oct 18, 2024

Conversation

cdkini
Copy link
Contributor

@cdkini cdkini commented Oct 18, 2024

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 19dabdd
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6712679b6a6bc00009bf0236

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (b973d08) to head (19dabdd).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...data_context/data_context/abstract_data_context.py 0.00% 1 Missing ⚠️
...xpectations/data_context/data_context_variables.py 0.00% 1 Missing ⚠️
...lumn_parameterized_distribution_ks_test_p_value.py 0.00% 1 Missing ⚠️
great_expectations/self_check/util.py 0.00% 1 Missing ⚠️
great_expectations/validator/validator.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10535   +/-   ##
========================================
  Coverage    80.11%   80.11%           
========================================
  Files          461      461           
  Lines        39991    39991           
========================================
  Hits         32038    32038           
  Misses        7953     7953           
Flag Coverage Δ
3.10 67.74% <0.00%> (ø)
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 clickhouse ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark ?
3.10 spark_connect ?
3.11 67.74% <0.00%> (ø)
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 clickhouse ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark_connect ?
3.11 trino ?
3.12 67.74% <0.00%> (ø)
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 55.23% <0.00%> (ø)
3.12 aws_deps 45.97% <0.00%> (ø)
3.12 big 54.60% <0.00%> (ø)
3.12 databricks 47.72% <0.00%> (ø)
3.12 filesystem 61.53% <16.66%> (ø)
3.12 mssql 50.09% <0.00%> (ø)
3.12 mysql 50.15% <0.00%> (ø)
3.12 postgresql 54.43% <0.00%> (ø)
3.12 snowflake 48.57% <0.00%> (ø)
3.12 spark 57.91% <0.00%> (ø)
3.12 spark_connect 46.28% <0.00%> (ø)
3.12 trino 52.52% <0.00%> (ø)
3.9 67.78% <0.00%> (ø)
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 55.24% <0.00%> (ø)
3.9 aws_deps 46.00% <0.00%> (ø)
3.9 big 54.62% <0.00%> (ø)
3.9 clickhouse 42.86% <0.00%> (ø)
3.9 databricks 47.74% <0.00%> (ø)
3.9 filesystem 61.54% <16.66%> (ø)
3.9 mssql 50.07% <0.00%> (ø)
3.9 mysql 50.13% <0.00%> (ø)
3.9 postgresql 54.41% <0.00%> (ø)
3.9 snowflake 48.59% <0.00%> (ø)
3.9 spark 57.88% <0.00%> (ø)
3.9 spark_connect 46.29% <0.00%> (ø)
3.9 trino 52.51% <0.00%> (ø)
cloud 0.00% <0.00%> (ø)
docs-basic 52.58% <0.00%> (ø)
docs-creds-needed 52.81% <0.00%> (ø)
docs-spark 52.22% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Kilo59 Kilo59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that's not the point of this PR, but all of these TRY203/TRY302 violations should be fixed (not necessarily in this PR).
And by fixed I mean we should remove the "useless" try/except.
But in the schema of things, low priority.
https://docs.astral.sh/ruff/rules/useless-try-except/

@cdkini cdkini enabled auto-merge October 18, 2024 14:11
@cdkini cdkini added this pull request to the merge queue Oct 18, 2024
Merged via the queue into develop with commit 65f6abb Oct 18, 2024
71 checks passed
@cdkini cdkini deleted the m/_/bump_ruff branch October 18, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants